Nir Soffer has posted comments on this change.
Change subject: vm: Fix attribute error when accessing drive in sampling method
......................................................................
Patch Set 1:
The race is not the problem. The problem is that the code treat attributes as dicts keys,
creating them dynamically, but does not check them as dict keys, assuming that they are
not there. The __slots__ patch solve this.
If there is another problem hiding behind this, it will be easier to debug when we have a
cleaner code. This patch is only the first step in understanding this issue, and user is
ready running with this path and sending us logs.
--
To view, visit
http://gerrit.ovirt.org/22518
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia50e8af94b9c9b54332066a3f30999ce73e7a56f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-HasComments: No