Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: support for block devices ......................................................................
Patch Set 4: Code-Review-1
(1 comment)
As pointed out by a user on ML the change breaks engine. VDSM fails to fetch disk size and logs an exception. Although the the disk size field is marked as optional in the scheme engine does not consider the size opotional aparently.
Maybe we should provide an alternative logic of fetching disk size for block devices. Adding -1 for the moment.
https://gerrit.ovirt.org/#/c/64272/2/tests/v2vTests.py File tests/v2vTests.py:
PS2, Line 130: {dis
yes,
Are you sure? Based on what I see in docs it's more like file attribute is for file and dev attribute is for block.