Ayal Baron has posted comments on this change.
Change subject: Added a support for a guest hibernate command.
......................................................................
Patch Set 8: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/API.py
Line 342: stats = v.getStats().copy()
Line 343: stats['vmId'] = self._UUID
Line 344: return {'status': doneCode, 'statsList': [stats]}
Line 345:
Line 346: def hibernate(self, target):
iiuc this breaks backwards compatibility.
We still need to support hibernating to an external device.
It's quite likely that we'll want to do so in the long run as well (i.e. it's
not even deprecated)
Line 347: """
Line 348: Hibernate a VM.
Line 349:
Line 350: :param target: Either "disk", "mem" or an opaque
string, indicating
--
To view, visit
http://gerrit.ovirt.org/1121
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ad6836e61e9d91ec6f46a599541f61ff12e9737
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <ghammer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server