Dan Kenigsberg has uploaded a new change for review.
Change subject: netinfo.speed: avoid log spam ......................................................................
netinfo.speed: avoid log spam
Some network device drivers, such as infiniband, do not expose their "speed". In such cases we report speed "0", and fill vdsm.log with a persistent exception traceback. With this patch, Vdsm no longer seem surprised by a nic with invalid speed pseudofile.
Change-Id: I4b03470139fb383fd03eaa2dc356539eae80d1c0 Signed-off-by: Dan Kenigsberg danken@redhat.com --- M lib/vdsm/netinfo.py 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/24197/1
diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py index 790c099..7d12bb3 100644 --- a/lib/vdsm/netinfo.py +++ b/lib/vdsm/netinfo.py @@ -297,6 +297,9 @@ s = int(speedFile.read()) if s not in (2 ** 16 - 1, 2 ** 32 - 1) or s > 0: return s + except IOError as ose: + if ose.errno != errno.EINVAL: + logging.exception('cannot read %s nic speed', dev) except Exception: logging.exception('cannot read %s speed', dev) return 0