Antoni Segura Puimedon has posted comments on this change.
Change subject: ethtool_opts: Add hook for applying network custom property ......................................................................
Patch Set 3:
I improved the output of the testing and fixed one of the test features name (tso).
The verification process consisted on:
toniel602 ~ # ethtool --show-offload eth2 Features for eth2: rx-checksumming: on tx-checksumming: on scatter-gather: on tcp-segmentation-offload: on udp-fragmentation-offload: on generic-segmentation-offload: on generic-receive-offload: off large-receive-offload: off ntuple-filters: off receive-hashing: off
On a python terminal: from vdsm import vdscli
c = vdscli.connect()
# Changing tcp-segmentation-offload for eht2 c.setupNetworks({'ethopt': {'nic': 'eth2', 'custom': {'ethtool_opts': '--offload eth2 tso off'}} }, {}, {'connectivityCheck': False})
back to bash: toniel602 ~ # ethtool --show-offload eth2 Features for eth2: rx-checksumming: on tx-checksumming: on scatter-gather: on tcp-segmentation-offload: off udp-fragmentation-offload: on generic-segmentation-offload: on generic-receive-offload: off large-receive-offload: off ntuple-filters: off receive-hashing: off toniel602 ~ #