Francesco Romani has posted comments on this change.
Change subject: osinfo: un-nest kernel version gathering function ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
worth switching now to logging.exception()? no big deal, your call.
https://gerrit.ovirt.org/#/c/65379/1/lib/vdsm/osinfo.py File lib/vdsm/osinfo.py:
Line 245: Line 246: def _runtime_kernel_version(): Line 247: ret = os.uname() Line 248: try: Line 249: ver, rel = ret[2].split('-', 1) I wonder if we can get this for free from the platform module Line 250: except ValueError: Line 251: logging.error('kernel release not found', exc_info=True) Line 252: ver, rel = '0', '0' Line 253:
PS1, Line 251: logging in another ([far] future) patch -> logging.exception