Change in vdsm[master]: vdsm-logrotate.conf: Add copytruncate

Zhou Zheng Sheng has posted comments on this change.

Change subject: vdsm-logrotate.conf: Add copytruncate
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/vdsm-logrotate.conf.in
Line 1: /var/log/vdsm/*.log {
Line 2:     rotate 100
Line 3:     copytruncate
I think copytruncate is not necessary.  In vdsm/logger.conf.in, the handler for vdsm.log is logging.handlers.WatchedFileHandler [1]. This handler examines the inode number and device number of vdsm.log before every write operation.  There is a default option "create" in /etc/logrotate.conf. After logrotate does its job, it creates a new and empty vdsm.log. The inode number of the new vdsm.log is changed, so WatchedFileHandler will close and re-open the vdsm.log .

[1] http://docs.python.org/2/library/logging.handlers.html#watchedfilehandler
Line 4:     missingok
Line 5:     size 15M
Line 6:     compress
Line 7:     compresscmd /usr/bin/xz

--
To view, visit http://gerrit.ovirt.org/13499
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie018b2039eac565cfdb5874c664b177d6fad64fa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server