Saggi Mizrahi has posted comments on this change.
Change subject: utils: Correct and faster list2cmdline ......................................................................
Patch Set 7:
(1 comment)
Minor suggestion
http://gerrit.ovirt.org/#/c/27548/7/lib/vdsm/utils.py File lib/vdsm/utils.py:
Line 731: Line 732: if not printable: Line 733: printable = command Line 734: Line 735: execCmdLogger.debug("%s (cwd %s)", _list2cmdline(printable), cwd) Even though the new function is a significant improvement I suggest we add:
if execCmdLogger.isEnabledFor(logging.DEBUG):
So that we don't even run _list2cmdline() if debug logging is turned off. Line 736: Line 737: p = CPopen(command, close_fds=True, cwd=cwd, env=env, Line 738: deathSignal=deathSignal, childUmask=childUmask) Line 739: if not sync: