Liron Ar has posted comments on this change.
Change subject: introducing capability to stream data to image
......................................................................
Patch Set 11:
(1 comment)
http://gerrit.ovirt.org/#/c/23281/11/vdsm/BindingXMLRPC.py
File vdsm/BindingXMLRPC.py:
Line 147: if not all((spUUID, sdUUID, imgUUID)):
Line 148: self.send_error(httplib.BAD_REQUEST,
Line 149: "missing or empty required header(s):"
Line 150: " spUUID=%s sdUUID=%s imgUUID=%s"
Line 151: % (spUUID, sdUUID, imgUUID))
You must return after sending error.
good catch, done.
Line 152:
Line 153: # Optional headers
Line 154: volUUID = self.headers.getheader(self.HEADER_VOLUME)
Line 155:
--
To view, visit
http://gerrit.ovirt.org/23281
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I768b84799ed9fb2769c6d4240519d036f8988b99
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar
laravot@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon
asegurap@redhat.com
Gerrit-Reviewer: Ayal Baron
abaron@redhat.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Federico Simoncelli
fsimonce@redhat.com
Gerrit-Reviewer: Liron Ar
laravot@redhat.com
Gerrit-Reviewer: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Sergey Gotliv
sgotliv@redhat.com
Gerrit-Reviewer: Tal Nisan
tnisan@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim
ybronhei@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes