Change in vdsm[master]: vdsm hostdev: add support for USB devices

Francesco Romani has posted comments on this change.

Change subject: vdsm hostdev: add support for USB devices
......................................................................

Patch Set 1:

(3 comments)

http://gerrit.ovirt.org/#/c/29054/1/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 3160: #
Line 3161: # Possible policies for startup with device
Line 3162: #
Line 3163: # @mandatory:   fail if missing for any reason (the default) 
Line 3164: #
trailing whitespace
Line 3165: # @requisite:   fail if missing on boot up, drop if missing
Line 3166: #               on migrate/restore/revert
Line 3167: #
Line 3168: # @optional:    drop if missing at any start attempt

Line 3164: #
Line 3165: # @requisite:   fail if missing on boot up, drop if missing
Line 3166: #               on migrate/restore/revert
Line 3167: #
Line 3168: # @optional:    drop if missing at any start attempt 
ditto
Line 3169: #
Line 3170: # Since: 4.16.0
Line 3171: ##
Line 3172: {'enum': 'StartupPolicy', 'data': ['mandatory', 'requisite', 'optional']}

http://gerrit.ovirt.org/#/c/29054/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1706: 
Line 1707:             rom.setAttrs(**romAttrs)
Line 1708: 
Line 1709:         elif self.capability == 'usb_device':
Line 1710:             addr = self.getPciAddr()
getUsbAddr maybe?
Line 1711:             try:
Line 1712:                 source.appendChildWithArgs('vendor', None, addr['vendor'])
Line 1713:                 source.appendChildWithArgs('vendor', None, addr['product'])
Line 1714:             except: