Dan Kenigsberg has submitted this change and it was merged.
Change subject: Avoid to recompile namedtuple ATTR classes in lvm.
......................................................................
Avoid to recompile namedtuple ATTR classes in lvm.
Re-defining the ??_ATTR classes may be hurting the performance
during the VM creation (preliminary). This patch avoids attribute
class creation each time the lvm object is recreated.
Should be noted that re-creating lvm cached objects during the VM
creation is not required, therefore paths modified by the actual
patch should not be called in such scenario.
This abnormal situation will be corrected in a following patch.
Dealing with variable attribute strings is not required for the
actual development of oVirt and the lvm module, then
_attr2NamedTuple() can be removed.
Change-Id: I66110a7f25fb5cfd80ddffe9a22e1cbac11de447
Signed-off-by: Eduardo <ewarszaw(a)redhat.com>
Reviewed-on:
http://gerrit.ovirt.org/25678
Tested-by: Meital bourvine <meitalbourvine(a)gmail.com>
Reviewed-by: Antoni Segura Puimedon <asegurap(a)redhat.com>
Reviewed-by: Yeela Kaplan <ykaplan(a)redhat.com>
Reviewed-by: Francesco Romani <fromani(a)redhat.com>
Reviewed-by: Saggi Mizrahi <smizrahi(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm/storage/lvm.py
1 file changed, 9 insertions(+), 17 deletions(-)
Approvals:
Yeela Kaplan: Looks good to me, but someone else must approve
Saggi Mizrahi: Looks good to me, but someone else must approve
Antoni Segura Puimedon: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Meital bourvine: Verified
Francesco Romani: Looks good to me, but someone else must approve
--
To view, visit
http://gerrit.ovirt.org/25678
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I66110a7f25fb5cfd80ddffe9a22e1cbac11de447
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Meital Bourvine <mbourvin(a)redhat.com>
Gerrit-Reviewer: Meital bourvine <meitalbourvine(a)gmail.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server