Francesco Romani has posted comments on this change.
Change subject: API: streamline and make setLogLevel correct ......................................................................
Patch Set 17: Verified+1
Verified both positive and negative flows:
Thread-111::DEBUG::2016-06-23 09:57:50,330::bindingxmlrpc::1245::vds::(wrapper) client [::1]::call setLogLevel with ('FOOBAR', '') {} Thread-111::ERROR::2016-06-23 09:57:50,330::bindingxmlrpc::1270::vds::(wrapper) unexpected error Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/vdsm/rpc/bindingxmlrpc.py", line 1248, in wrapper res = f(*args, **kwargs) File "/usr/lib/python2.7/site-packages/vdsm/rpc/bindingxmlrpc.py", line 649, in setLogLevel return api.setLogLevel(level, name) File "/usr/share/vdsm/API.py", line 1382, in setLogLevel logUtils.set_level(level, name) File "/usr/lib/python2.7/site-packages/vdsm/logUtils.py", line 237, in set_level raise ValueError("unknown log level: %r" % level) ValueError: unknown log level: 'FOOBAR' Thread-111::INFO::2016-06-23 09:57:50,332::xmlrpc::91::vds.XMLRPCServer::(_process_requests) Request handler for ::1:52199 stopped
Thread-114::DEBUG::2016-06-23 09:58:25,394::bindingxmlrpc::1245::vds::(wrapper) client [::1]::call setLogLevel with ('WARNING', '') {} Thread-114::WARNING::2016-06-23 09:58:25,394::logUtils::243::root::(set_level) Setting loglevel on 'root' to WARNING (30) Thread-114::DEBUG::2016-06-23 09:58:25,394::bindingxmlrpc::1253::vds::(wrapper) return setLogLevel with {'status': {'message': 'Done', 'code': 0}}