Federico Simoncelli has posted comments on this change.
Change subject: upgrade: reallocate the metadata slots when needed ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File vdsm/storage/imageRepository/formatConverter.py Line 133: # Using the internal call to skip the domain V3 validation, Line 134: # see volume.setrw for more details. Line 135: vol._setrw(True) Line 136: Line 137: def v3ReallocateMetadataSlot(domain, vol): Actually now that I think of it we probably need two different reallocations depending on the domain version (V1/V2). Line 138: metaOffset = vol.getMetaOffset() Line 139: Line 140: if metaOffset < BLKVOL_MAX_OFFSET: Line 141: return
-- To view, visit http://gerrit.ovirt.org/9660 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I15b6a85969a10b5e2b852031fc510aabcc2d5276 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com