From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: move hooks to common ......................................................................
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/79695/12/lib/vdsm/common/hook/hooking.py File lib/vdsm/common/hook/hooking.py:
Line 41: import os Line 42: import sys Line 43: from xml.dom import minidom Line 44: Line 45: from vdsm.commands import execCmd
common package should not depend on the vdsm package.
Ouch. I wonder how I failed to notice this. execCmd is exposed to hooks (one hook is even using sync=False!), so we cannot easily avoid having it in common. Line 46: from vdsm.common.conv import tobool Line 47: from vdsm.common import hooks Line 48: Line 49: # make pyflakes happy