Ayal Baron has posted comments on this change.
Change subject: Avoid hsm image deletions.
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/fileSD.py
Line 512: self.log.debug("Unmounting stale file system %s",
Line 513: self.mountpoint)
Line 514: mount.getMountFromTarget(self.mountpoint).umount()
Line 515: raise se.FileStorageDomainStaleNFSHandle()
Line 516: raise
in continuation with comments on patch set 1 (you got -1 and did not make any changes,
resubmitting with only rebase is annoying).
anyway, it does not repeat any logic.
currently the system leaves garbage in some (too many) cases.
Point here is for spm to do some cleanup.
Your removal of it means that we will not be cleaning anything up.
Since the image has already been marked for deletion and since this is on files, it is
perfectly safe to delete it (even when called from the wrong place).
The call should be moved to someplace where it makes more sense in general (i.e. for block
domains as well)
Line 517:
Line 518: def templateRelink(self, imgUUID, volUUID):
Line 519: """
Line 520: Relink all hardlinks of the template 'volUUID' in all VMs based
on it.
--
To view, visit
http://gerrit.ovirt.org/17193
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1ec2ea8793a4ad63453559bc5f663b65f9b9336
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server