Dan Kenigsberg has posted comments on this change.
Change subject: setVmTicket: add before and after hooks ......................................................................
Patch Set 7: (2 inline comments)
.................................................... File vdsm/hooks.py Line 51: scriptenv.update(params) In my opinion it is a too limiting interface... but I'm not 100% sure.
.................................................... File vdsm/vdsmd.8.in Line 74: suggested text: (not sure)
before_vm_set_ticket and after_vm_set_ticket hooks receive a variable called "params" with a json-encoded value that was passed by setVmTicket caller.
-- To view, visit http://gerrit.ovirt.org/3565 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I48cbc934e48055630b734a2d3c79c72b6c36f28f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shavivi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Shahar Havivi shavivi@redhat.com