Eduardo has posted comments on this change.
Change subject: Reduce the number of getVolumeSize() calls. ......................................................................
Patch Set 3:
(1 comment)
.................................................... File vdsm/storage/blockVolume.py Line 188: dom.sdUUID, volUUID, exc_info=True) Line 189: Line 190: return (dom.sdUUID, mdSlot) Line 191: Line 192: def delete(self, zeroLen, force): The issue here is (by now) delete is a volume method but geting the volume size should be (and getVSize is) a SD method.
The Volume.getVolumeSize is wrong since there is nothing in the Volume object related or capable to get the size of the backing volume.
This whole module, including delete, will be removed solving the present dicotomy. Line 193: """ Delete volume Line 194: 'zeroLen' - zeroes to write before file deletion. Line 195: 'force' is required to remove shared and internal volumes Line 196: """