Change in vdsm[master]: utils: Add changehash function for change detection

Francesco Romani has posted comments on this change.

Change subject: utils: Add changehash function for change detection
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/33045/3/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 1169:     h = hashlib.md5()
Line 1170:     for s in strings:
Line 1171:         h.update(s)
Line 1172:     # Engine stores this in varchar(30)
Line 1173:     return h.hexdigest()[:30]
I wonder if this alter the properties of the hash like the distribution. IIRC it should
not, and a quick google search seems to confirm
http://stackoverflow.com/questions/8184941/uniform-distribution-of-trunca...


-- 
To view, visit http://gerrit.ovirt.org/33045
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2242a594383e2d2fe64e3a581f18b8ac662648b0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes