Nir Soffer has posted comments on this change.
Change subject: schedule: Introduce scheduling libary
......................................................................
Patch Set 3:
Saggi, new code in vdsm use pep8 style, for example:
- vdsm/protocoldetector.py
- http://gerrit.ovirt.org/29392
If most of us prefer this style, why should we punish ourself with the style of vdsm? The only person how likes this style is Ayal, and he is not contributing to vdsm lately :-)
I think we should keep current modules in the same style they are, and add new modules in pep8 style. But Dan prefer to add *all* new code in this style.
--
To view, visit
http://gerrit.ovirt.org/29607
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3764806d93bd37c3b5924080eb5ae4d29e4f4e0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Allon Mureinik
amureini@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon
asegurap@redhat.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Federico Simoncelli
fsimonce@redhat.com
Gerrit-Reviewer: Francesco Romani
fromani@redhat.com
Gerrit-Reviewer: Martin Sivák
msivak@redhat.com
Gerrit-Reviewer: Michal Skrivanek
michal.skrivanek@redhat.com
Gerrit-Reviewer: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Saggi Mizrahi
smizrahi@redhat.com
Gerrit-Reviewer: Yoav Kleinberger
ykleinbe@redhat.com
Gerrit-Reviewer: automation@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No