Nir Soffer has posted comments on this change.
Change subject: rwlock: Add simpler RWLock
......................................................................
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/42908/10/lib/vdsm/rwlock.py
File lib/vdsm/rwlock.py:
Line 75: Lock promotion or demotion is forbidden and will raise RuntimeError.
Line 76: """
Line 77:
Line 78: def __init__(self):
Line 79: self.shared = Context(self, False)
This is little more clear, but I don't like to call positional
arguments in
New version make this code much more clear using another way.
Line 80: self.exclusive = Context(self, True)
Line 81: self._lock = threading.Lock()
Line 82: self._waiters = []
Line 83: self._readers = set()
--
To view, visit
https://gerrit.ovirt.org/42908
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2466c137c89598772fb46347eb02195916883cac
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes