Bala.FA has posted comments on this change.
Change subject: Added gluster tag support in getAllTasks() ......................................................................
Patch Set 2: (2 inline comments)
.................................................... File vdsm/storage/taskManager.py Line 157: msg = 'Files moved: %d, Moving file: %s' % \ Line 158: (status['filesMoved'], status['movingFile']) Line 159: state = status['status'] Line 160: except ge.GlusterException: Line 161: self.log.error("gluster exception occured", exc_info=True) Done Line 162: Line 163: subRes[taskId] = {"id": taskId, Line 164: "verb": value['volumeName'], Line 165: "state": state,
Line 193: elif 'gluster' in tag: Line 194: subRes.update(self._getAllGlusterTasks()) Line 195: except ge.GlusterException: Line 196: self.log.error("gluster exception occured", exc_info=True) Line 197: Gluster tasks don't fit in current task framework and they are managed by gluster itself. We need a way to expose them into engine so that they will be treated normally like other tasks.
Based on this requirement, Current way of exposing gluster tasks is good I think. Line 198: self.log.debug("Return: %s", subRes) Line 199: return subRes Line 200: Line 201: def unloadTasks(self, tag=None):
-- To view, visit http://gerrit.ovirt.org/7579 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9c765cbfebb5ba22f0d21efa04c824ea4daf6432 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server