Federico Simoncelli has posted comments on this change.
Change subject: bz#831938 raise exception when error occurs in connectStorageServer ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
.................................................... File vdsm/storage/hsm.py Line 1937: self.log.error("Could not connect to storageServer", exc_info=True) Line 1938: raise Line 1939: # Connecting new device may change the visible storage domain list Line 1940: # so invalidate caches Line 1941: sdCache.invalidateStorage() connectStorageServer receives a list of connections and returns a list of results (e.g. which connections succeeded and which ones failed). At the present time we cannot modify that for backward compatibility. More importantly in the change you're suggesting there's no feedback on what connections succeeded before failing (raise). Line 1942: Line 1943: @deprecated Line 1944: def _connectStorageOverIser(self, conDef, conObj, conTypeId): Line 1945: """