Dan Kenigsberg has posted comments on this change.
Change subject: Have direct file not use the O_DIRECT flag on tmpfs and ramfs ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
any chance you split this patch according to the substantial/cosmetic line?
.................................................... File vdsm/storage/fileUtils.py Line 188: curMode = statinfo[stat.ST_MODE] Line 189: if curMode != mode: Line 190: raise OSError(errno.EPERM, Line 191: ("Existing %s permissions %s are not as " Line 192: "requested %s") % (dirPath, I hate these pep8 fixes which are unrelated to the patch. They confuse and waste reviewer time, as well as future git-blamers. Line 193: oct(curMode), Line 194: oct(mode))) Line 195: Line 196:
-- To view, visit http://gerrit.ovirt.org/9595 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7db4136c1a34d960b17312c2c785fc3234b24b92 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com