Mark Wu has posted comments on this change.
Change subject: Skip monitoring the usage of tmpfs filesystems in diskStats ......................................................................
Patch Set 3: (1 inline comment)
.................................................... File vdsm/sampling.py Line 160: for p in self.MONITORED_PATHS: Line 161: rc, out, _ = utils.execCmd(['stat', '--file-system', '--format=%T', Line 162: p]) Line 163: if rc == 0 and out[0] == 'tmpfs': Line 164: continue Good point! But in current Host sampling code, it has the same effect of putting it into __init__ and _getDiskStats, because it create a new instance of HostSample in every sampling. You approach will show its advantadge after we refactor the host sampling code. Line 165: Line 166: free = 0 Line 167: try: Line 168: stat = os.statvfs(p)