Federico Simoncelli has posted comments on this change.
Change subject: Add the hostId parameter to reconstructMaster ......................................................................
Patch Set 13: (6 inline comments)
.................................................... File vdsm/storage/hsm.py Line 1489: pool = sp.StoragePool(spUUID, self.taskMng) Done
.................................................... File vdsm/storage/sp.py Line 732: temporaryLock = None see below
Line 738: if not self.id and not hostId: The use of a real hostId is disjoint from the new flow where you don't disconnect. So I definitely agree on checking the version to make sure we reconstruct while connected only with v3, but I don't see any particular advantage on forbidding a real hostid for version < 3.
Line 745: temporaryLock = False see below
Line 750: safeLease) The missing indentation in the last part of your comment it made hard to understand.
self.refresh(...) # here below, line 751
Takes care of:
sdCache.refresh(...) self.__rebuild(...)
The only missing thing is (hopefully):
self.__createMailboxMonitor()
Line 764: elif temporaryLock == False: Currently it can: it's a final clause where we could end up if _acquireTemporaryClusterLock or acquireHostId+acquireClusterLock are failing. In such case we shouldn't be releasing anything here. I'll improve this moving the _acquireTemporaryClusterLock and acquireHostId+acquireClusterLock out of the try section.
-- To view, visit http://gerrit.ovirt.org/5068 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If665af4ed8be9b5b53dffc7e1fc258b818bf7f98 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com