Dan Kenigsberg has posted comments on this change.
Change subject: Fix failure of adding bridgeless network with skipping libvirt
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
(2 inline comments)
....................................................
Commit Message
Line 7: Fix failure of adding bridgeless network with skipping libvirt
actually, you do not fix the failure, you make it fail gracefully.
....................................................
File vdsm/configNetwork.py
Line 508: # Option skipLibvirt should not be true when add a bridgeless
I usually like comments, but this one says exactly what the exception text below says..
--
To view, visit
http://gerrit.ovirt.org/3919
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia61fab631e8eecf3dc698a94d72858d7a72ade08
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shu Ming <sming56(a)gmail.com>