Saggi Mizrahi has uploaded a new change for review.
Change subject: Properly raise OSError in betterPopen ......................................................................
Properly raise OSError in betterPopen
Change-Id: I2429093229aa1f98263b1d9eb1b5557d49ce52fd Signed-off-by: Saggi Mizrahi smizrahi@redhat.com --- M vdsm/betterPopen/createprocess.c 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/9592/1
diff --git a/vdsm/betterPopen/createprocess.c b/vdsm/betterPopen/createprocess.c index a57cbae..499bed6 100644 --- a/vdsm/betterPopen/createprocess.c +++ b/vdsm/betterPopen/createprocess.c @@ -289,7 +289,8 @@ safeClose(errnofd[1]); errnofd[1] = -1; if (read(errnofd[0], &childErrno, sizeof(int)) == sizeof(int)) { - PyErr_SetString(PyExc_OSError, strerror(childErrno)); + errno = childErrno; + PyErr_SetFromErrno(PyExc_OSError); goto fail; }
-- To view, visit http://gerrit.ovirt.org/9592 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I2429093229aa1f98263b1d9eb1b5557d49ce52fd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com