Yaniv Bronhaim has posted comments on this change.
Change subject: Packaging: fix libvirt configuration
......................................................................
Patch Set 1:
(3 comments)
why does it depend on
http://gerrit.ovirt.org/#/c/20142/3 ?
....................................................
Commit Message
Line 8:
Line 9: The help string "=FILE" is incorrectly added to the name of the
Line 10: configure option --with-libvirt-service-default. So This patch moves
Line 11: "=FILE" to help string.
Line 12:
I would split between the two fixes.
Line 13: Another problem is we disabled libvirt-sanlock in Ubuntu, so QLCONF is
Line 14: set to "/dev/null", but later we need to grep
"${BY_VDSM_VERS}" from
Line 15: QLCONF to confirm libvirt is configured. grep returns 1 for QLCONF but
Line 16: actually libvirt is configured. This patch does not set QLCONF to
Line 14: set to "/dev/null", but later we need to grep
"${BY_VDSM_VERS}" from
Line 15: QLCONF to confirm libvirt is configured. grep returns 1 for QLCONF but
Line 16: actually libvirt is configured. This patch does not set QLCONF to
Line 17: "/dev/null", this is harmless because when libvirt-sanlock is not
Line 18: enabled, no one reads and cares QLCONF actually.
but that way we'll get "no such file or directory" when we'll try to
echo to that file if it doesn't exist.. that what we actually want to avoid
Line 19:
Line 20: Change-Id: I34fa3764b999e71186171931664b0481b2ef3a15
....................................................
File lib/vdsm/tool/libvirt_configure.sh.in
Line 19: #
Line 20:
Line 21: . @LIBEXECDIR(a)/ovirt_functions.sh
Line 22:
Line 23: ENABLE_LIBVIRT_SANLOCK="@ENABLE_LIBVIRT_SANLOCK@"
well, so this should be removed too
Line 24: ENABLE_LIBVIRT_SELINUX="@ENABLE_LIBVIRT_SELINUX@"
Line 25:
Line 26: GETCONFITEM="@VDSMDIR@/get-conf-item"
Line 27: VDSM_CONF_FILE="@CONFDIR(a)/vdsm.conf"
--
To view, visit
http://gerrit.ovirt.org/20168
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34fa3764b999e71186171931664b0481b2ef3a15
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes