Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Do not mix local and universal time, improve tests ......................................................................
Patch Set 3: Verified+1
(1 comment)
http://gerrit.ovirt.org/#/c/24192/3/tests/functional/dhcp.py File tests/functional/dhcp.py:
Line 61: Line 62: Line 63: def runDhclient(interface, confFile, leaseFile, pidFile): Line 64: """Starts dhclient and hands the process over after a while.""" Line 65: rc, out, err = execCmd([_DHCLIENT_BINARY.cmd, '-lf', leaseFile, Of course dhclient stays up after getting a lease even with a timeout set (it is only relevant in getting a lease for the first time).
I can live without dhclient's debug mode, can be found in the Journal. Line 66: '-pf', pidFile, '-timeout', str(_DHCLIENT_TIMEOUT), Line 67: '-1', '-cf', confFile, interface]) Line 68: Line 69: if rc: # == 2