Yeela Kaplan has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
......................................................................
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/15/configure.ac
File configure.ac:
Line 164: ,
Line 165: [enable_m2c="yes"]
Line 166: )
Line 167: AM_CONDITIONAL([M2C], [test "${enable_m2c}" = "yes"])
Line 168:
do we really want this? users should know what they want to configure in vd
I tend to agree with you Yaniv.
This is what we have vdsm.conf for.
Line 169: # Users and groups
Line 170: AC_SUBST([VDSMUSER], [vdsm])
Line 171: AC_SUBST([VDSMGROUP], [kvm])
Line 172: AC_SUBST([METADATAUSER], [vdsm])
--
To view, visit
https://gerrit.ovirt.org/44689
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9881d11e30ced9c34bfe602bba3d968f57e0fe15
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
piotr.kliczewski@gmail.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Francesco Romani
fromani@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Piotr Kliczewski
piotr.kliczewski@gmail.com
Gerrit-Reviewer: Sandro Bonazzola
sbonazzo@redhat.com
Gerrit-Reviewer: Simone Tiraboschi
stirabos@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim
ybronhei@redhat.com
Gerrit-Reviewer: Yeela Kaplan
ykaplan@redhat.com
Gerrit-Reviewer: automation@ovirt.org
Gerrit-HasComments: Yes