Francesco Romani has posted comments on this change.
Change subject: execCmd: no need to pass the default sudo=False value ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Good cleanup, but looks like the parameter was accidentally took away from the function definition too (since the default here is sudo=False as well).
http://gerrit.ovirt.org/#/c/24145/1/lib/vdsm/utils.py File lib/vdsm/utils.py:
Line 555: def __del__(self): Line 556: self._poller.close() Line 557: Line 558: Line 559: def execCmd(command, cwd=None, data=None, raw=False, logErr=True, Well, we need the sudo parameter here! :) Line 560: printable=None, env=None, sync=True, nice=None, ioclass=None, Line 561: ioclassdata=None, setsid=False, execCmdLogger=logging.root, Line 562: deathSignal=0, childUmask=None): Line 563: """