Ido Barkan has posted comments on this change.
Change subject: testSetupNetworksAddDelDhcp: Check that a DHCPv4 address is in range ......................................................................
Patch Set 3: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/36186/3/tests/functional/networkTests.py File tests/functional/networkTests.py:
Line 390: addr_to_int = _ipv4_to_int if family == 4 else _ipv6_to_int Line 391: range_from = addr_to_int(range_from) Line 392: range_to = addr_to_int(range_to) Line 393: passes = (range_from <= addr_to_int(a) <= range_to for a in addrs) Line 394: self.assertTrue(any(passes), 'no address {0} in expected range'.format( please explain why any address is string enough for this assertion Line 395: addrs)) Line 396: Line 397: def testLegacyBonds(self): Line 398: if not (caps.getos() in (caps.OSName.RHEVH, caps.OSName.RHEL)