Federico Simoncelli has posted comments on this change.
Change subject: vmDevices: add mechanism to persist vmDevice defaults ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
I'd like to see _defaults being renamed.
http://gerrit.ovirt.org/#/c/21066/3/vdsm/vm.py File vdsm/vm.py:
Line 1249: pass Line 1250: self.conf = conf Line 1251: self.log = log Line 1252: self._deviceXML = None Line 1253: self._defaults() Can we rename this to something like: _initializeDefaults(...) or something better. Line 1254: Line 1255: def _defaults(self): Line 1256: pass Line 1257: