Nir Soffer has posted comments on this change.
Change subject: sp: fix spm start when failing to produce domain ......................................................................
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/25424/3/vdsm/storage/sp.py File vdsm/storage/sp.py:
Line 206: if domain.getDomainRole() == sd.REGULAR_DOMAIN: Line 207: continue Line 208: Line 209: self._backend.setDomainRegularRole(domain) Line 210: except se.StorageDomainDoesNotExist:
iirc, this error can be raised only from within sdc.produce(). So either th
We need to catch exception raised in getDomainRole and in setDomainRole. Line 211: self.log.error("Error when trying to find domain %s, ignoring", Line 212: sdUUID, exc_info=True) Line 213: Line 214: @unsecured