Eduardo has posted comments on this change.
Change subject: vm: new parameter 'protected' for vm creation ......................................................................
Patch Set 4: Code-Review-1
Please consider:
The shared element is optional and actually sent by the engine by default 'false'.
IMHO it should be used for shared = ('Exclusive', 'Shared', 'None') and we do not need extra parameters, since is sent today by default 'false'. For BC (using use_volume_leases) set: None if shared == 'false'. 'Shared' if shared == 'True'
Instead 'protected', the VM protected, will sent 'Exclusive'.
The required changes are minimal, in getConfDrives() set the default to None and in getXML() acting properly. And changing the engine default when you want VMs being protected by default.