Yaniv Bronhaim has posted comments on this change.
Change subject: libvirtconnection: ping libvirt upon disconnection
......................................................................
Patch Set 3:
(1 comment)
....................................................
File lib/vdsm/libvirtconnection.py
Line 90: libvirt.VIR_ERR_NO_CONNECT,
Line 91: libvirt.VIR_ERR_INVALID_CONN)
Line 92: if edom in EDOMAINS and ecode in ECODES:
Line 93: if not vdsmLibvirtPing:
Line 94: conn.getLibVersion(vdsmLibvirtPing=True)
btw, why not using conn = __connections.get(id(target)) -
you have target here, instead of passing conn
Line 95: else:
Line 96: log.error('connection to libvirt broken.'
Line 97: ' ecode: %d edom: %d', ecode, edom)
Line 98: if killOnFailure:
--
To view, visit
http://gerrit.ovirt.org/19444
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia489e46dd8ce4c70c888988d17b86311d3c4b935
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes