Saggi Mizrahi has posted comments on this change.
Change subject: Add deathSignal options to better popen ......................................................................
Patch Set 13: (1 inline comment)
.................................................... File vdsm/betterPopen/createprocess.c Line 315: rv = read(errnofd[0], &childErrno, sizeof(int)); Line 316: if (rv < 0) { Line 317: switch (errno) { Line 318: case EINTR: Line 319: case EAGAIN: I already knew that EAGAIN is impossible. I just thought I'll put it here and be done with it. I don't think this fix merits another iteration. Line 320: break; Line 321: default: Line 322: PyErr_SetString(PyExc_OSError, strerror(childErrno)); Line 323: goto fail;
-- To view, visit http://gerrit.ovirt.org/6241 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server