Dan Kenigsberg has posted comments on this change.
Change subject: net_tc: add support for mirroring all (not just IPv4) traffic ......................................................................
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/27388/2/vdsm/network/tc.py File vdsm/network/tc.py:
Line 202: if out is None: Line 203: out = _process_request([EXT_TC, 'filter', 'show', 'dev', dev, Line 204: 'parent', parent]) Line 205: Line 206: HEADER = 'filter protocol all pref ' I think we face a serious issue upon upgrade: if a host has ip4-only filters defined, an updated Vdsm would recognize none of them, and would never clean them up. Line 207: prio = handle = None Line 208: actions = [] Line 209: prevline = ' ' Line 210: for line in out.splitlines() + [HEADER + 'X']: