Shahar Havivi has posted comments on this change.
Change subject: improve add/del bridgesless network ......................................................................
Patch Set 1: (4 inline comments)
.................................................... File vdsm/configNetwork.py Line 323: self._removeFile(self.NET_CONF_PREF + bridge) why did you remove the check?
Line 737: subprocess.call([constants.EXT_BRCTL, 'delbr', network]) why isn't this code in removeBridge? the same for removeVlan...
.................................................... File vdsm/netinfo.py Line 99: mtu = "0" I am not sure zero default ok... the default is 1500...
Line 266: if len(ports(netname)) != 0: this is the old version that we use the ports instead of libvirt network, the reason that we change to libvirt is that we have networks that have no actual bridge. Dan what do you say?
-- To view, visit http://gerrit.ovirt.org/3615 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7f170eaced2d6f756b84cb52e9efce6dc9722405 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Shahar Havivi shavivi@redhat.com