Antoni Segura Puimedon has posted comments on this change.
Change subject: Report legacy bond devices instead of actually creating them
......................................................................
Patch Set 1: Code-Review-1
(5 comments)
Some insignificant issues and one test suggestion.
Thanks for this patch. I'm glad to get rid of this!
http://gerrit.ovirt.org/#/c/28455/1//COMMIT_MSG
Commit Message:
Line 6:
Line 7: Report legacy bond devices instead of actually creating them
Line 8:
Line 9: Engine <= 3.2 expects to see bonding devices bond0-bond4 predefined on
Line 10: each host. Therefor, Vdsm creates them on boot, and never deletes them.
I believe this "Therefor" should be "Therefore", it fits more to the
meaning.
Line 11: This add cumbersome logic, which has lead to bugs.
Line 12:
Line 13: Instead, this patch simply reports the existence of the 5 expected
Line 14: bonds, instead of actually creating them.
http://gerrit.ovirt.org/#/c/28455/1/lib/vdsm/tool/load_needed_modules.py.in
File lib/vdsm/tool/load_needed_modules.py.in:
Line 1: # Copyright IBM, Corp. 2012
I think we can add RedHat 2014 ;-)
Line 2: #
Line 3: # This program is free software; you can redistribute it and/or modify
Line 4: # it under the terms of the GNU General Public License as published by
Line 5: # the Free Software Foundation; either version 2 of the License, or
http://gerrit.ovirt.org/#/c/28455/1/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 1: #
Line 2: # Copyright 2013 Red Hat, Inc.
2013-2014
Line 3: # This program is free software; you can redistribute it and/or modify
Line 4: # it under the terms of the GNU General Public License as published by
Line 5: # the Free Software Foundation; either version 2 of the License, or
Line 6: # (at your option) any later version.
Line 262: def assertMtu(self, mtu, *elems):
Line 263: for elem in elems:
Line 264: self.assertEquals(int(mtu), int(self.vdsm_net.getMtu(elem)))
Line 265:
Line 266: @cleanupNet
I don't think that this test needs any cleanup.
Line 267: def testLegacyBonds(self):
Line 268: for b in _REQUIRED_BONDINGS:
Line 269: self.assertBondExists(b, [])
Line 270:
http://gerrit.ovirt.org/#/c/28455/1/vdsm/caps.py
File vdsm/caps.py:
Line 1: #
Line 2: # Copyright 2011 Red Hat, Inc.
2011-2014
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or
--
To view, visit
http://gerrit.ovirt.org/28455
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4028a70cc8fd3e0599f02ac339a783a7d85f045e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes