Change in vdsm[master]: virt: add support to cancel the core dump of a VM.

Francesco Romani has posted comments on this change.

Change subject: virt: add support to cancel the core dump of a VM.
......................................................................


Patch Set 15:

(1 comment)

http://gerrit.ovirt.org/#/c/11130/15/vdsm/virt/coredump.py
File vdsm/virt/coredump.py:

Line 49:         if postAction:
Line 50:             self.flags |= CoreDumpThread.postActionFlags[postAction]
Line 51:         if bypassCache:
Line 52:             self.flags |= libvirt.VIR_DUMP_BYPASS_CACHE
Line 53:         self.memoryOnly = memoryOnly
>  What is this needed for? 
Looks like is no longer needed. Will
remove.
Line 54:         if memoryOnly:
Line 55:             self.flags |= libvirt.VIR_DUMP_MEMORY_ONLY
Line 56: 
Line 57:         self.status = {'code': CoreDumpThread.Status.NONE,


-- 
To view, visit http://gerrit.ovirt.org/11130
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes