Mark Wu has posted comments on this change.
Change subject: Replace calling setSchedulerParameters() with filling its XML description. ......................................................................
Patch Set 3: (2 inline comments)
.................................................... File vdsm/libvirtvm.py Line 501 Line 502 Line 503 Line 504 Line 505 This niceness is only used to represent vm's priority in ovirt internal. Is it necessary to make it comply with linux scheduler's niceness.
Line 504: MAX_NICENESS = 19 Line 505: MIN_NICENESS = -19 Line 506: DEFAULT_VM_PRIO = 20 Line 507: DEFAULT_CGROUP_CPUSHARE = 1024 Line 508: CPUSHARE_SCALE_FACTOR = DEFAULT_CGROUP_CPUSHARE / DEFAULT_VM_PRIO The cpu share value is relative. It doesn't matter what the absolute value is. The cpu share of all vms are calculated according to the same rule, so I think it should be fine. Line 509: Line 510: def __init__(self, conf, log): Line 511: """ Line 512: Create the skeleton of a libvirt domain xml
-- To view, visit http://gerrit.ovirt.org/6290 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I211e191022f5a18fa7d97d5a8fb42e10729ddd06 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Laszlo Hornyak lhornyak@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com