Eduardo has posted comments on this change.
Change subject: Adding [start|stop]MonitoringDomain().
......................................................................
Patch Set 1:
(1 comment)
....................................................
File vdsm/storage/sp.py
Line 1545: # {sdUUID1: status1, sdUUID2: status2, ...}
Line 1546: self.invalidateMetadata()
Line 1547: poolDoms = self.getDomains()
Line 1548: activeDomains = tuple(sdUUID for sdUUID in poolDoms
Line 1549: if poolDoms[sdUUID] == sd.DOM_ACTIVE_STATUS)
This change is required since being StoragePool.domainMonitor a pointer to a unique hsm
instance. monitoredDomains member includes the extra-pool SDs, added with
startMonitoringDomain. Therefore these extra pool SDs will be removed from the monitor
with the old code, due to the iteration over monitoredDomains.
Line 1550: monitoredDomains = self.domainMonitor.monitoredDomains
Line 1551:
Line 1552: for sdUUID in poolDoms:
Line 1553: if sdUUID not in activeDomains:
--
To view, visit
http://gerrit.ovirt.org/19762
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Gadi Ickowicz <gickowic(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes