Nir Soffer has posted comments on this change.
Change subject: tests: Add test for terminating a terminated process ......................................................................
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/65328/6/tests/utilsTests.py File tests/utilsTests.py:
Line 114: self.proc.terminate() Line 115: self.proc.wait() Line 116: Line 117: def fail(): Line 118: raise RuntimeError("Attempt to kill a terminated process")
I see that copy and paste are our friends :)
Did you notice that each exception has different text?
Please suggest how to improve this while keeping the code clear. Line 119: Line 120: self.proc.kill = fail Line 121: with utils.terminating(self.proc): Line 122: pass