Federico Simoncelli has posted comments on this change.
Change subject: sp: fix spm start when failing to produce domain ......................................................................
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/25424/2/vdsm/storage/sp.py File vdsm/storage/sp.py:
Line 209: Line 210: self._backend.setDomainRegularRole(domain) Line 211: except Exception: Line 212: # log any exception, but keep going Line 213: self.log.error("Error trying to check/update domain %s role",
Federico, I am afraid I disagree. If we can live with with two domains with
Once we'll drop the storage pool we won't call startSpm anymore and this part will be kept only to deal with old data centers. This is not a matter of master/ovirt-3.4 branches, it's a matter of removing something that was part of the format (and we'll have to assess if older vdsm may have a problem with that). If we end up with 2 masters and we find an issue, the problem would be fixed as easily as re-electing the spm. On the contrary if you remove the code we'll have to handle the bug somehow (what if it's in old versions?). Line 214: sdUUID, exc_info=True) Line 215: Line 216: @unsecured Line 217: def startSpm(self, prevID, prevLVER, maxHostID, expectedDomVersion=None):