Mark Wu has posted comments on this change.
Change subject: logging: setup log filter correctly ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Do you know any reason why python doesn't support filter in fileConfig? Submmit a a patch for it?
.................................................... File vdsm/logUtils.py Line 162: except: Line 163: self.handleError(record) Line 164: Line 165: Line 166: def getFilteredClass(logHandlerClass, *filters): is it better to use getFilteredLogHandler Line 167: class Filtered(logHandlerClass): Line 168: def __init__(self, *args, **kwargs): Line 169: logHandlerClass.__init__(self, *args, **kwargs) Line 170: for aFilter in filters:
-- To view, visit http://gerrit.ovirt.org/9688 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I76c2f77c95dd44853f070c8f7b7a8b71cfd6866c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com