Timothy Asir has posted comments on this change.
Change subject: gluster: Get size information of a gluster volume ......................................................................
Patch Set 8:
(1 comment)
.................................................... File client/vdsClientGluster.py Line 457: params = self._eqSplit(args) Line 458: volumeName = params.get('volumeName', '') Line 459: if not volumeName: Line 460: raise ValueError('volumeName is required parameter') Line 461: vdsmcli also treated as a functional testing tool. We need to test the state (of glusterVolumeStatsInfoGet) when engine calls this funciton without volumeName. So, this volumeName null check should be there inside the glusterVolumeStatsInfoGet function. Line 462: status = self.s.glusterVolumeStatsInfoGet(volumeName) Line 463: pp.pprint(status) Line 464: return status['status']['code'], status['status']['message'] Line 465: