From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: move exec_sync_bytes to common.cmdutils
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/79693/4/lib/vdsm/common/cmdutils.py
File lib/vdsm/common/cmdutils.py:
Line 111: Memory = 'Memory'
Line 112: BlockIO = 'BlockIO'
Line 113:
Line 114:
Line 115: def exec_sync_bytes(cmds):
Please rename it to run().
Are you asking me for a (limited)
backport of python3's subprocess.run? If so, why?
I am looking for a bare-bone version of execCmd, to be used in network/* and hooks.py;
Using run(check=True) to achieve cleaner code all over Vdsm should not be part of this
task.
It is important for me to express that my out/err is kept in bytes. Each user should know
that it is responsible to decoding, if needed.
Line 116: logging.debug(command_log_line(cmds))
Line 117:
Line 118: p = Popen(
Line 119: cmds, close_fds=True, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
--
To view, visit
https://gerrit.ovirt.org/79693
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idca5b123a4ce6ef5ebaff8084d788e2acd47c2be
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes