David Caro has posted comments on this change.
Change subject: [WIP] Automation scripts for running vdsm functional tests job ......................................................................
Patch Set 3:
(3 comments)
https://gerrit.ovirt.org/#/c/41928/3/automation/check-patch.req File automation/check-patch.req:
Line 1: yum
Who will maintain the duplicate requirements?
Yep, if it's properly defined in the spec, you can build the rpm and install it, or similar to get the deps, but as long as it's not handled you will have to add it here too.
Until now we did it in the jenkins jobs directly, and that made patches break each time there was a new dep Line 2: sudo Line 3: dhclient Line 4: autoreconf Line 5: gettext-devel
https://gerrit.ovirt.org/#/c/41928/3/automation/check-patch.sh File automation/check-patch.sh:
Line 1: #!/bin/bash -e Line 2: # Line 3: # Run on each patch to gerrit, should be faster than check-meged and require Line 4: # less resources but thorough enough to provide relevant feedback
David: we need more specific contract with the ci
Nop, there's only 0 or 1, if you don't want to fail the pass, return 0, if you do, return != 0. No need for a third state Line 5: Line 6: echo "Hello - ifra functional tests" Line 7: Line 8: ./autogen.sh --system; make rpm NOSE_EXCLUDE=.*
Line 5: Line 6: echo "Hello - ifra functional tests" Line 7: Line 8: ./autogen.sh --system; make rpm NOSE_EXCLUDE=.* Line 9: yum install ~/rpmbuild/RPMS/noarch/vdsm*
Errors are ignored - we should check and handle error for each command.
set -e breaks execution if there are any failed commands Line 10: Line 11: Line 12: vdsm-tool configure --force Line 13: service vdsmd start