Ayal Baron has posted comments on this change.
Change subject: fix check None sdUUID for getVmsList and getVmsInfo ......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/storage/hsm.py Line 1136: self.validateBackupDom(sdUUID) This will break the moment we start storing OVFs on all the domains (we would like to do this because then there is no dependency on master domain and we could import existing domains and run VMs from vdsm directly without manager even if master domain is not available etc).
So I think we should remove this validation. If the user passed a domain which doesn't have any OVFs on it we should just make sure to fail gracefully.
-- To view, visit http://gerrit.ovirt.org/3560 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I27fe906e6738320279bc44f9736acaa97131d7ee Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com